-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to reject update and revert operations if there are any file conflicts #714
Conversation
6d0760c
to
f534b1b
Compare
@yersan this adds an option to reject the update/revert if any file conflicts are detected, like we talked last week. |
@spyrkob Question, as long as there is a deployment, the standalone.xml / domain.xml will be modified; it means that practically 100% of the installations will generate a conflict when copying these configuration files (and other files used to tweak the launch script environment). How does Prospero work in that regard? I mean, if the update does not contain any configuration file change (as it should be), would a conflict be detected always when the full structure of the candidate server is applied? If so, it sounds reasonable to exclude from the conflict checks the files that are expected can be modified by the user. So, even if It would be great if we have the possibility to just check the conflicts by using a candidate server without the |
The conflicts only occur if both the user and the incoming update changes the same file. If only the user changed a file, this file will be preserved. If only the update modified the file, the file will be updated. If the file was modified in both, the resolution via .glold/.glnew will be done.
Sure we can add a method like |
At Prospero command line, it could be useful if you are trying to minimize the downtime and you want to reject any conflicts. |
I'll add this functionality to this PR next week |
cfeaa2c
to
cb15571
Compare
@yersan FYI I added a |
cb15571
to
be95772
Compare
be95772
to
ae203cf
Compare
ae203cf
to
35c33ab
Compare
35c33ab
to
ce517a1
Compare
Add
--no-conflicts-only
argument to update and revert operations.When
--no-conflicts-only
argument is present, theapply
andperform
operations should fail if any file conflicts are detected. An error code (1) should be returned and no changes to the installation should be applied.Requires wildfly-extras/wildfly-installation-manager-api#20